Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala][Client]Add Http4s scala3 client codegen #19658

Merged
merged 19 commits into from
Oct 5, 2024

Conversation

JennyLeahy
Copy link
Contributor

@JennyLeahy JennyLeahy commented Sep 23, 2024

A new code generator that generates scala3 http4s client.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@clasnake, @shijinkui, @ramzimaalej, @chameleon82, @Bouillie @Fish86

@JennyLeahy JennyLeahy changed the title Add Http4s scala3 client codegen [Scala][Client]Add Http4s scala3 client codegen Sep 23, 2024
@JennyLeahy
Copy link
Contributor Author

@wing328 any chance to review this? Thanks.

@wing328
Copy link
Member

wing328 commented Oct 5, 2024

@wing328 wing328 merged commit 9791e6f into OpenAPITools:master Oct 5, 2024
26 of 27 checks passed
@wing328
Copy link
Member

wing328 commented Oct 5, 2024

fyi. filed and merged #19786 with minor improvements.

@wing328
Copy link
Member

wing328 commented Oct 5, 2024

FYI. For the excludeSbt, excludeApi options, one can use the openapiGeneatorIgnoreList option instead to exclude whatever files they want as part of the code generation: https://openapi-generator.tech/docs/customization/#ignore-file-format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants